This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libI77: Automatically regenerate config.h.in
- To: gcc-patches at gcc dot gnu dot org
- Subject: Re: libI77: Automatically regenerate config.h.in
- From: Alexandre Oliva <aoliva at redhat dot com>
- Date: 17 May 2001 15:37:35 -0300
- Organization: GCC Team, Red Hat
- References: <u8ofst6q90.fsf@gromit.moeb>
On May 16, 2001, Andreas Jaeger <aj@suse.de> wrote:
> Could some configure experts look over this, please?
> Ok to commit?
> +${srcdir}/config.h.in: stamp-h.in
You're missing the `; @true' here.
> +config.h: stamp-h; @true
> +stamp-h: config.h.in config.status
> + $(SHELL) config.status
You'd better define CONFIG_FILES= CONFIG_HEADERS=config.h so that
config.status doesn't needlessly (and perhaps incorrectly) rebuilds
Makefile. Please consider the patch with these changes pre-approved
for mainline and branch.
I still think things might have been simpler if we just kept not using
config.h at all. However, if there are lots of macros AC_DEFINEd in
configure.in, having them all in DEFS might overflow command-line
lengths on old OSs, which are exactly those that would generally need
the DEFS in the first place. So moving on to config.h is a step in
the right direction, and now that you've already done almost all of
the work, I no longer see a reason to go back.
It would be nice to have contrib/gcc_update updated to touch
stamp-h.in and config.h.in.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me