Re: [PATCH] style fix for aix51.h and rs6000/mach.h

["David O'Brien" <obrien at FreeBSD dot org>]

On Thu, May 03, 2001 at 02:03:47PM -0400, David Edelsohn wrote:
> David,
> 
> tm_file="${tm_file} rs6000/aix.h rs6000/rs6000.h rs6000/aix.h rs6000/aix51.h"

Again, please explain in detail why this is not the same exact sequence
of includes pre and post-commit.  I am simply not seeing it.


> And now you seem to want to push it onto Franz and Geoff
> and me to fix up your mistake.

No, I am fully willing to fix any mistakes I make.  Geoff has not asked
for me to back out my commit.  If I get such an email from him (or other
person that approves my commits), I'll do it in a second.

If I make mistakes I need to be made aware of them.  Not just told "your
a fscking idiot".  Pointing out where the problem is (and why it is a
problem) is a productive approach.


> 	Your attitude shows little respect for anyone else and little care
> for targets other than FreeBSD, 

I do care for other targets, and I don't know where you're pulling this
from.


> so you should not be surprised that your patches need to be more
> carefully scrutinized and reviewed before they are committed.

I 110% *want* my patches to be scrutinized.  I believe strongly in code
review (which I see this as a form of).


> P.S. Calling me names is not acceptable for this mailinglist.

I did not call you any "names" in this mailing list.  I did send you a
*private* email calling you on the carpet for what I felt was a slap in
the face from you.
 
-- 
-- David  (obrien@FreeBSD.org)