Re: [PATCH] Fix cpp to match cpp.texi in respect to warnings

[Neil Booth <neil at daikokuya dot demon dot co dot uk>]

Jakub Jelinek wrote:-

> cpp.texi sais about -Wcomment that it enables warning whenever
> backslash-newline appears in a // comment, but in reality this warning is
> issued unconditionally. Likewise, cpp.texi speaks about -Wwhite-space, but
> the warning is unconditional too.
> This patch changes cpp0 to match its documentation.
> Bootstrapped on i386-redhat-linux, no regressions.
> Ok to commit?

The Wcomment line is fine for branch and mainline.

As for -Wwhite-space, I never knew that existed.  It must have been in cccp;
I don't believe it was ever intended to be handled in cpplib.  IIRC I just
put in the cpplib warning because I noticed it was in one place and easy
to do (after a discussion by Per about why it might be useful to allow
such stuff without failing).

I'd rather just drop -Wwhite-space from the docs; I think we should
always warn.  But I don't feel strongly about it; Zack may have a
different opinion.  If we decide to keep it, the documentation should
be made clearer too - it is the only case where this option is used,
and not just an example.

Neil.