This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to remove putenv definition from gcc.c
- To: dave at hiauly1 dot hia dot nrc dot ca
- Subject: Re: Patch to remove putenv definition from gcc.c
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Tue, 27 Mar 2001 18:07:40 -0500 (EST)
- Cc: gcc-patches at gcc dot gnu dot org
> From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
>
> > We redundantly define putenv in gcc.c, we should use the putenv in
> > libiberty if needed. Patch tested on solaris2.7, no regressions.
> >
> > Ok to install?
> >
> > --Kaveh
> >
> >
> > 2001-03-26 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * configure.in: Don't check for putenv.
> > * configure: Regenerate.
> > * gcc.c (putenv): Don't define.
>
> The last change will cause further VMS breakage. The libiberty
> version of putenv isn't suitable for VMS. The putenv defined in
> gcc.c was a nop for VMS and this behavior is lost with your patch.
> Dave
The alpha/xm-vms.h port hardcodes #define HAVE_PUTENV, so as currently
written, gcc.c won't define putenv() at all. Somehow its already
working there without the NOP.
My understanding from previous posts is that the vax vms port is
broken and whoever wants to resurrect it will have to start with the
alpha one (or from scratch) anyway.
With this in mind, do you still object?
--Kaveh
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions