This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: OK to commit? - mishandled SIGCHLD ICE
- To: 'Marc Aurele La France' <tsi at ualberta dot ca>, Bruce Korb <bkorb at gnu dot org>, "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>
- Subject: RE: OK to commit? - mishandled SIGCHLD ICE
- From: Bruce Korb <bkorb at allegronetworks dot com>
- Date: Fri, 9 Mar 2001 07:55:01 -0800
> Anyway, here's a few more comments, based on the patch
> against 2.7.2.* I
> submitted way back when. (Some might no longer apply).
>
> 1) After, #include'ing <signal.h>, you should
>
> #if !defined(SIGCHLD) && defined(SIGCLD)
> #define SIGCHLD SIGCLD
> #endif
Yep. This is needed.
> 2) Wrap the signal(SIGCHLD, SIG_DFL) with an #ifdef SIGCHLD /
> #endif pair.
> Same reason, except for even older systems.
Does GCC even work if there is no SIGC[H]LD?
Shouldn't hurt, tho.
> 3) collect2.c, protoize.c and toplev.c need the same fix, not
> just gcc.c.
protoize.c, yes. The others are invoked indirectly via gcc.
Once gcc is fixed, its spawn are already fixed. I'll spin
patches next week.