Re: Patch review - any way to expedite?

[Geoff Keating <geoffk at geoffk dot org>]

Toshi Morita <tm2@best.com> writes:

> Is there any additional information I can supply to expediate the
> acceptance of the patch I mentioned in these messages?
> 
> http://gcc.gnu.org/ml/gcc-bugs/2001-02/msg00658.html
> http://gcc.gnu.org/ml/gcc-bugs/2001-02/msg00648.html
> 
> The patch seems fairly simple, and I'd like to see it included
> in both gcc-2.95.3 and gcc-3.0 as it's causing severe problems
> for some of our developers.

I've looked at this patch, and it has these problems:

- In general, you should delete code rather than using #if to comment it out.
  Also, there is no need to leave comments in the compiler explaining
  why wrong ways to do things are wrong; do it the right way
  and explain that if necessary.

- Is this patch needed for the mainline?  If not, please find the mainline
  patch that fixed the problem and submit that instead.

- I don't see why the patch is correct.  It seems that this is exactly
  the situation where force_to_mode should be called.  Are you sure
  the bug isn't somewhere else (like in force_to_mode, or in the next
  line of code)?

> Also, I noticed there's no maintainer specifically mentioned
> for the combiner in the MAINTAINERS file - does combine.c
> have an official maintainer?

I don't believe so.

-- 
- Geoffrey Keating <geoffk@geoffk.org>