Re: PATCH: Darwin / Mac OS X native support

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Thursday 01 March 2001 23:28, Stan Shebs wrote:
> Index: gcc/config.gcc
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config.gcc,v
> retrieving revision 1.32
> diff -c -3 -p -r1.32 config.gcc
> *** config.gcc	2001/02/26 18:15:36	1.32
> --- config.gcc	2001/03/01 21:54:29
> *************** powerpc-*-beos*)
> *** 2689,2696 ****
> --- 2689,2703 ----
>   	xmake_file=rs6000/x-beos
>   	;;
>   powerpc-*-darwin*)
> + 	cpu_type=rs6000
> + 	tm_file=rs6000/darwin.h
           ^^^^^^^^^^^^^^^^^^^^^^^
The rs6000 directory was just cleaned from old-style includes recently, so 
this should read

> + 	tm_file="${tm_file} darwin.h rs6000/darwin.h"

and the corresponding #include's removed from your header files.
config/darwin.h also seems to contain a lot of unnecessary #undef's, rs6000.h 
got cleaned up a lot from OS dependent defines since gcc-2.95, so you should 
be able to clean it up a bit. Feel free to suggest some macros for move from 
rs6000.h to the OS headers too, if you think they prevent cleanly structured 
darwin OS headers.
On the other hand I don't think PREFERRED_RELOAD_CLASS belongs in an OS 
header...

Overall the patch is looking good at a first glance, and unless Geoff and 
David have major concerns with it, I guess it can go into 3.0? The 
FINALIZE_PIC stuff maybe controversial, I believe this hook is deprecated and 
no new targets should use it, so most probably you will have to find a 
different solution...

Franz.