This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] m68k: don't try to push bytes
- To: Graham Stott <grahams at redhat dot com>
- Subject: Re: [patch] m68k: don't try to push bytes
- From: Richard Henderson <rth at redhat dot com>
- Date: Wed, 28 Feb 2001 14:23:58 -0800
- Cc: DJ Delorie <dj at redhat dot com>, gcc-patches at gcc dot gnu dot org
- References: <200102282029.PAA26079@greed.delorie.com> <3A9D6158.E7209E94@redhat.com>
On Wed, Feb 28, 2001 at 08:36:40PM +0000, Graham Stott wrote:
> > + /* We want to avoid trying to push bytes. */
> > + #define MOVE_BY_PIECES_P(SIZE, ALIGN) \
> > + (move_by_pieces_ninsns (SIZE, ALIGN) < MOVE_RATIO) \
> > + && ((SIZE >=16 && ALIGN >= 16) || TARGET_5200)
> > +
> Suggest you parenthesis the macro parameters to avoid surprises.
Speaking of parenthesis, There's a pair around the < that is
unneeded, and not one around the entire expression, which is.
But why would 5200 want to allow byte pushing when 68000 doesn't?
r~