This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] m68k: don't try to push bytes


On Wed, Feb 28, 2001 at 08:36:40PM +0000, Graham Stott wrote:
> > + /* We want to avoid trying to push bytes. */
> > + #define MOVE_BY_PIECES_P(SIZE, ALIGN) \
> > +   (move_by_pieces_ninsns (SIZE, ALIGN) < MOVE_RATIO) \
> > +     && ((SIZE >=16 && ALIGN >= 16) || TARGET_5200)
> > +
> Suggest you parenthesis the macro parameters to avoid surprises.

Speaking of parenthesis, There's a pair around the < that is
unneeded, and not one around the entire expression, which is.

But why would 5200 want to allow byte pushing when 68000 doesn't?


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]