This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Patch: libiberty/choose_temp.c replace mktemp with mkstemp

To: schmid at snake dot iap dot physik dot tu-darmstadt dot de
Subject: Re: Patch: libiberty/choose_temp.c replace mktemp with mkstemp
From: DJ Delorie <dj at redhat dot com>
Date: Wed, 28 Feb 2001 14:29:43 -0500
CC: gcc-patches at gcc dot gnu dot org
References: <Pine.LNX.4.21.0102281834080.23762-100000@snake.iap.physik.tu-darmstadt.de>


> The call of mktemp() is considered as a potential security
> risk. Thus, the following patch replaces it with mkstemp in the file
> libiberty/choose-temp.c. After applying the appended patch, I
> bootstrapped the compiler and ran the testsuites. There were no
> regressions.

(1) Did you try bootstrapping on systems that don't provide mkstemp?

(2) mkstemp opens the file, but you never close it.  In fact, you
    don't save the file descriptor at all.

References:
- Patch: libiberty/choose_temp.c replace mktemp with mkstemp
  - From: Peter Schmid

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]