This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Bug in Objective-C compiler found


On Tue, Feb 20, 2001 at 10:59:53AM -0800, Zack Weinberg wrote:
> - an opinion from C front end experts on whether true non-keywords
>   ever appear in declspecs.

No can do.  Perhaps Joseph Myers knows?

> - a review of the appended patch, which I am bootstrapping now.

But this I can.

> 	* stringpool.c (set_identifier): New function.
> 	* tree.h: Prototype it.
> 	
> 	* c-parse.in: Kill D_YES. If compiled for objc, call
> 	save_and_forget_protocol_qualifiers from init_reswords.
> 	* objc/objc-act.c (remember_protocol_qualifiers,
> 	forget_protocol_qualifiers): Don't diddle C_IS_RESERVED_WORD.
> 	Swap out the non-keyword IDENTIFIER_NODEs for keyword ones, or
> 	vice versa.
> 	(save_and_forget_protocol_qualifiers): New function.
> 	* c-lex.h: Prototype save_and_forget_protocol_qualifiers.

This is arguably less bletcherous than frobbing C_IS_RESERVED_WORD.
Given that it fixes the test cases, I think it's ok for mainline and
branch (since it's an objc regression from 2.95).


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]