This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: VAX PATCH: remove FILE_NAME_NONDIRECTORY


> I might be missing something, but all of GCC uses libiberty, and CPP uses
> basename amongst other things from libiberty.
> 
> So I don't see why toplev.c should be different, and how you could break
> something that isn't already broken.
> 
> Or have I completely misunderstood what you're trying to achieve?

There is only one place basename is used: mkdeps.c.  In general,
it appears that an effort was made to avoid it.  Here is a comment from
ChangeLog.1:

Mon May 17 23:56:39 1999  Alexandre Oliva  <oliva@dcc.unicamp.br>

        * Makefile.in (stmp-fixproto): Pass location of mkinstalldirs to
	fixproto.
	* fixproto: Avoid unportable constructs such as `basename' and
	`mkdir -p'.  Use mkinstalldirs from the environment if `mkdir -p'
	fails.

The libiberty version only builds if the system doesn't have it.  However,
the system version isn't portable according to the above comment.  This
probably is an argument for libiberty to always build basename.  Then, gcc
could likely use it.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]