This is the mail archive of the
mailing list for the GCC project.
Re: VAX PATCH: remove FILE_NAME_NONDIRECTORY
- To: neil at daikokuya dot demon dot co dot uk (Neil Booth)
- Subject: Re: VAX PATCH: remove FILE_NAME_NONDIRECTORY
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- Date: Thu, 22 Feb 2001 15:19:16 -0500 (EST)
- Cc: gcc-patches at gcc dot gnu dot org
> I might be missing something, but all of GCC uses libiberty, and CPP uses
> basename amongst other things from libiberty.
> So I don't see why toplev.c should be different, and how you could break
> something that isn't already broken.
> Or have I completely misunderstood what you're trying to achieve?
There is only one place basename is used: mkdeps.c. In general,
it appears that an effort was made to avoid it. Here is a comment from
Mon May 17 23:56:39 1999 Alexandre Oliva <email@example.com>
* Makefile.in (stmp-fixproto): Pass location of mkinstalldirs to
* fixproto: Avoid unportable constructs such as `basename' and
`mkdir -p'. Use mkinstalldirs from the environment if `mkdir -p'
The libiberty version only builds if the system doesn't have it. However,
the system version isn't portable according to the above comment. This
probably is an argument for libiberty to always build basename. Then, gcc
could likely use it.
J. David Anglin firstname.lastname@example.org
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)