This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: add multiple include guards

To: Richard Henderson <rth at redhat dot com>, Matt Kraai <kraai at alumni dot carnegiemellon dot edu>, gcc-patches at gcc dot gnu dot org
Subject: Re: add multiple include guards
From: "Zack Weinberg" <zackw at stanford dot edu>
Date: Wed, 21 Feb 2001 18:32:15 -0800
References: <20010221150630.A12722@opensource.lineo.com> <20010221175259.C1843@redhat.com>

On Wed, Feb 21, 2001 at 05:52:59PM -0800, Richard Henderson wrote:
> On Wed, Feb 21, 2001 at 03:06:30PM -0700, Matt Kraai wrote:
> > 	__GCC_FILENAME_H__
> 
> No leading underscores.  That's in the implementation's namespace.

We've already got a ton of headers that do guards with leading
underscores (in four or so different styles).  They are, of course,
all wrong.

Matt, would you care to change this patch to use GCC_FILENAME_H
throughout (I don't see any need for extra trailing underscores) and
then send a follow up which changes all the existing guards to be
consistent?

Also, you haven't looked at any of the subdirectories.  The guard
there should be GCC_DIR_FILENAME_H to avoid clashes.

zw

References:
- add multiple include guards
  - From: Matt Kraai
- Re: add multiple include guards
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]