This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

SH config files still refer to flag_new_abi


Joern,

I see you had planned to switch over to word-sized bools when the new
ABI was enabled.

However, the new ABI says `sizeof(bool)' should be 1 on all
platforms.  Do we really want SH to be incompatible with the ABI?  Is
the performance boost worth it?

I'd rather install this patch and let the new ABI's standard value to
be used.  Ok with you?

Index: gcc/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* config/sh/sh.h (BOOL_TYPE_SIZE): Don't define.

Index: gcc/config/sh/sh.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/sh/sh.h,v
retrieving revision 1.96
diff -u -p -r1.96 sh.h
--- gcc/config/sh/sh.h 2001/02/07 05:43:59 1.96
+++ gcc/config/sh/sh.h 2001/02/15 12:07:02
@@ -1670,13 +1670,6 @@ extern int current_function_anonymous_ar
 /* Nonzero if access to memory by bytes is no faster than for words.  */
 #define SLOW_BYTE_ACCESS 1
 
-/* Force sizeof(bool) == 1 to maintain binary compatibility; otherwise, the
-   change in SLOW_BYTE_ACCESS would have changed it to 4.  */
-
-/* This used to use INT_TYPE_SIZE / CHAR_TYPE_SIZE, but these are
-   not guaranteed to be defined when BOOL_TYPE_SIZE is used.  */
-#define BOOL_TYPE_SIZE (flag_new_abi ? BITS_PER_WORD : BITS_PER_UNIT)
-
 /* We assume that the store-condition-codes instructions store 0 for false
    and some other value for true.  This is the value stored for true.  */
 

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]