This is the mail archive of the
mailing list for the GCC project.
Re: SSE scalar fp comparison patterns
- To: Jan Hubicka <jh at suse dot cz>
- Subject: Re: SSE scalar fp comparison patterns
- From: Richard Henderson <rth at redhat dot com>
- Date: Tue, 13 Feb 2001 02:29:54 -0800
- Cc: gcc-patches at gcc dot gnu dot org, patches at x86-64 dot org
- References: <20010213102703.C17317@atrey.karlin.mff.cuni.cz>
On Tue, Feb 13, 2001 at 10:27:03AM +0100, Jan Hubicka wrote:
> *************** ix86_prepare_fp_compare_args (code, pop0
> + int is_sse = SSE_REG_P (op0) | SSE_REG_P (op1);
Why would ix86_prepare_fp_compare_args be dealing with sse hard registers
already? Are you just being prepared to handle sse global registers?
> ! /* For sane SSE instruction set generation we need fcomi instruction. It is
> ! safe to enable all CMOVE instructions. */
> ! #define TARGET_CMOVE ((x86_cmove & (1 << ix86_arch)) || TARGET_SSE)
The biggest problem is the definition of the -msse (etc) options. It
really should be -march=p3 or -march=i686-sse or something. In any
case, this doesn't seem right. A slightly better solution without
mucking -mfoo entirely is to tweek things in override_options.
The rest of the patch I can't properly review until you catch up
with your merging. This is a first. ;-) The line numbers don't
match up properly and I can't really tell what order the new patterns
are in wrt the old ones.