This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: One more optimize_mode_switching() problem

On Fri, Feb 09, 2001 at 05:38:06PM -0200, Alexandre Oliva wrote:
> +#ifdef NORMAL_MODE
> +  n_basic_blocks++;
> +#endif

I think you really need some more commentary here.

> +		  else if (GET_CODE (src_bb->end) == INSN
> +			   || GET_CODE (src_bb->end) == CALL_INSN)

This is wrong.  If a CALL_INSN ends a block with an abnormal edge,
it is for exception handling and you can't put stuff after it there
any more than you could with a sibcall at the end of the function.

Fix those and the patch is ok.


r~
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]