This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: remembering comparison modes
- To: dj at redhat dot com
- Subject: Re: remembering comparison modes
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Date: Mon, 29 Jan 2001 04:40:24 +0100
- CC: gcc-patches at gcc dot gnu dot org
> Date: Tue, 23 Jan 2001 23:53:18 -0500
> From: DJ Delorie <dj@redhat.com>
> Index: combine.c
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/combine.c,v
> retrieving revision 1.178
> diff -p -2 -r1.178 combine.c
> *** combine.c 2001/01/17 18:27:37 1.178
> --- combine.c 2001/01/24 04:19:47
> *************** combine_simplify_rtx (x, op0_mode, last,
> *** 3656,3659 ****
> --- 3656,3661 ----
> if (cmp_mode == VOIDmode)
> cmp_mode = GET_MODE (XEXP (x, 1));
> + if (cmp_mode == VOIDmode)
> + cmp_mode = op0_mode;
> temp = simplify_relational_operation (code, cmp_mode,
> XEXP (x, 0), XEXP (x, 1));
Hey, this is
<URL:http://gcc.gnu.org/ml/gcc-patches/2000-11/msg01349.html>,
but with less comments!
Geoff K's comment to the request for approval and analysis then,
was "No, the values should be canonical", then followed a
discussion about modes on comparisons and modes on CONST_INT:s
which lead to no action.
> RCS file: /cvs/gcc/gcc/gcc/simplify-rtx.c,v
Anyway you seem to have fixed a corresponding bug in
simplify-rtx.c too, and since in the end the bugs are fixed, I'm
happy, FWIW.
brgds, H-P