This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Java lexer badly broken


Tom Tromey <tromey@redhat.com> writes:

> >>>>> "Richard" == Richard Earnshaw <rearnsha@arm.com> writes:
> 
> Richard> I don't see how this could ever have worked, since on just
> Richard> about every machine I can think of EOF=-1 so the check for a
> Richard> character being less than 128 will always be true.
> 
> It works by accident, because UEOF is also -1.
> 
> I agree that your patch is good, but I don't have approval permission.

Oops. I wrote the original code :-(

Please go ahead. Thanks.

./A


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]