This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Java lexer badly broken
- Subject: Re: Java lexer badly broken
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- Date: 25 Jan 2001 00:15:43 -0800
- Cc: gcc-patches at gcc dot gnu dot org, rearnsha at arm dot com, tromey at cygnus dot com
- References: <200101241120.LAA03714@cam-mail2.cambridge.arm.com><87d7dc4ym9.fsf@creche.redhat.com>
Tom Tromey <tromey@redhat.com> writes:
> >>>>> "Richard" == Richard Earnshaw <rearnsha@arm.com> writes:
>
> Richard> I don't see how this could ever have worked, since on just
> Richard> about every machine I can think of EOF=-1 so the check for a
> Richard> character being less than 128 will always be true.
>
> It works by accident, because UEOF is also -1.
>
> I agree that your patch is good, but I don't have approval permission.
Oops. I wrote the original code :-(
Please go ahead. Thanks.
./A