This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] to libf2c: #include <sys/types.h> for time_t
- To: Michael Sokolov <msokolov at ivan dot Harhan dot ORG>
- Subject: Re: [patch] to libf2c: #include <sys/types.h> for time_t
- From: Toon Moene <toon at moene dot indiv dot nluug dot nl>
- Date: Tue, 23 Jan 2001 23:18:35 +0100
- CC: gcc-patches at gcc dot gnu dot org
- Organization: Moene Computational Physics, Maartensdijk, The Netherlands
- References: <0101231850.AA01896@ivan.Harhan.ORG>
Michael Sokolov wrote:
> Toon Moene <toon@moene.indiv.nluug.nl> wrote:
> > Shouldn't this be:
> >
> > + #ifdef HAVE_SYS_TYPES_H
> > + #include <sys/types.h>
> > + #endif
> >
> > ?
> I thought that by the GNU standards <sys/types.h> was assumed to be always
> present like <stdio.h> and such, at least that's what I see in most GNU code.
> In any case, if you want to support <sys/types.h> not being present, you'd also
> need to add the check to configure.in, not just the ifdef.
Hmmm, good point - I made this comment because I looked in "a"
configure.in file that contained AC_CHECK_HEADERS(... sys/types.h ...)
However, gcc/libjava/configure.in is the only one showing up in a
grep sys/types `find gcc -name configure.in -print`
so apparently I was looking in the wrong place.
Consider your patch approved.
Thanks,
--
Toon Moene - mailto:toon@moene.indiv.nluug.nl - phoneto: +31 346 214290
Saturnushof 14, 3738 XG Maartensdijk, The Netherlands
Maintainer, GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
Join GNU Fortran 95: http://g95.sourceforge.net/ (under construction)