This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix bug 595
Jason Merrill wrote:
> OK, except that I'm confused by this comment.
>
> > ! /* Clear non-lang_specific flags. */
> > ! TYPE_LANG_FLAG_0 (t) = 0;
No, that's not a good comment, here's what I installed.
nathan
--
Dr Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
'But that's a lie.' - 'Yes it is. What's your point?'
nathan@codesourcery.com : http://www.cs.bris.ac.uk/~nathan/ : nathan@acm.org
2001-01-18 Nathan Sidwell <nathan@codesourcery.com>
* class.c (duplicate_tag_error): Robustify flag clearing.
Index: cp/class.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/cp/class.c,v
retrieving revision 1.355
diff -c -3 -p -r1.355 class.c
*** class.c 2001/01/10 23:06:26 1.355
--- class.c 2001/01/19 09:26:23
*************** duplicate_tag_error (t)
*** 2375,2399 ****
TYPE_CONTEXT (t) = NULL_TREE;
TYPE_NONCOPIED_PARTS (t) = NULL_TREE;
! TYPE_HAS_NONTRIVIAL_DESTRUCTOR (t) = 0;
! TYPE_HAS_CONSTRUCTOR (t) = 0;
! TYPE_HAS_DESTRUCTOR (t) = 0;
! TYPE_HAS_CONVERSION (t) = 0;
! TYPE_HAS_ASSIGN_REF (t) = 0;
! TYPE_HAS_CONST_ASSIGN_REF (t) = 0;
! TYPE_HAS_INIT_REF (t) = 0;
! TYPE_HAS_CONST_INIT_REF (t) = 0;
! TYPE_HAS_NEW_OPERATOR (t) = 0;
! TYPE_HAS_ARRAY_NEW_OPERATOR (t) = 0;
! TYPE_HAS_DEFAULT_CONSTRUCTOR (t) = 0;
! CLASSTYPE_HAS_MUTABLE (t) = 0;
! CLASSTYPE_NON_POD_P (t) = 0;
! CLASSTYPE_NEARLY_EMPTY_P (t) = 0;
! CLASSTYPE_NON_AGGREGATE (t) = 0;
! TYPE_HAS_REAL_ASSIGN_REF (t) = 0;
! TYPE_HAS_COMPLEX_ASSIGN_REF (t) = 0;
! TYPE_HAS_ABSTRACT_ASSIGN_REF (t) = 0;
! TYPE_HAS_COMPLEX_INIT_REF (t) = 0;
}
/* Make the BINFO's vtablehave N entries, including RTTI entries,
--- 2375,2390 ----
TYPE_CONTEXT (t) = NULL_TREE;
TYPE_NONCOPIED_PARTS (t) = NULL_TREE;
! /* Clear TYPE_LANG_FLAGS -- those in TYPE_LANG_SPECIFIC are cleared above. */
! TYPE_LANG_FLAG_0 (t) = 0;
! TYPE_LANG_FLAG_1 (t) = 0;
! TYPE_LANG_FLAG_2 (t) = 0;
! TYPE_LANG_FLAG_3 (t) = 0;
! TYPE_LANG_FLAG_4 (t) = 0;
! TYPE_LANG_FLAG_5 (t) = 0;
! TYPE_LANG_FLAG_6 (t) = 0;
! /* But not this one. */
! SET_IS_AGGR_TYPE (t, 1);
}
/* Make the BINFO's vtablehave N entries, including RTTI entries,