This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [v3] libstdc++/944/1019/1057/others


>>>>> "Benjamin" == Benjamin Kosnik <bkoz@redhat.com> writes:

> !   gribble::gribble()
> !   : _M_private_data(0), _M_more_stuff(0), _M_helper(0);
> --- 99,106 ----
> !   gribble::gribble() :
> !   _M_private_data(0), _M_more_stuff(0), _M_helper(0);

This change breaks with the GNU C convention of putting the operator on the
next line.  Any reason to do so?

> + 13. Spacing WRT return statements.
> +    no extra spacing before returns

This doesn't seem like something that needs a rule.  In my own code,
sometimes I have an extra line before the return, sometimes not, depending
on the grouping of the code that comes before it.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]