This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to consolidate builtins.c parameter checking into a function
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: Patch to consolidate builtins.c parameter checking into a function
- From: Bernd Schmidt <bernds at redhat dot com>
- Date: Sat, 30 Dec 2000 16:05:58 +0000 (GMT)
- Cc: <gcc-patches at gcc dot gnu dot org>
On Sat, 30 Dec 2000, Kaveh R. Ghazi wrote:
> 2000-12-29 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * builtins.c (validate_arglist): New function, use it.
> + /* This signifies an endlink, if no arguments remain, return
> + true, otherwise return false. */
> + va_end (ap);
> + return (arglist == 0);
Minor style nit - lose the parentheses around the return value.
I'm also not sure I like mixing enum values and integer constants (0),
but I can't think of a good tree code to use for the ellipsis.
Otherwise ok. I assume you made a basic sanity check to test that
builtins are still recognized?
Bernd