This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Prevent stack corruption in mark_*_resources


On Dec 30, 2000, Richard Henderson <rth@redhat.com> wrote:

> On Sat, Dec 30, 2000 at 04:41:19AM -0200, Alexandre Oliva wrote:
>> Nope.  The `>=' tests should been `>', as I originally tested the
>> patch.  Infamous last-minute obviously-correct changes :-(

> Eh?  Surely >= FIRST_PSEUDO_REGISTER is correct.

That's what fooled me too :-)

last_regno was a bad name.  It's actually the 1+last_regno.

Should I change the way it's computed, use <= for the loop and >= for
the sanity check?

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]