This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Irix build fails in gcc/fixinc
- To: David dot Billinghurst at riotinto dot com
- Subject: Re: Irix build fails in gcc/fixinc
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Thu, 14 Dec 2000 13:19:59 -0500 (EST)
- Cc: bkorb at gnu dot org, gcc-bugs at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
> From: "Billinghurst, David (CRTS)" <David.Billinghurst@riotinto.com>
>
> Irix6.5 build fails in gcc/fixinc with todays cvs. Probably introduced in
> the last day or so.
>
> Error is:
>
> cc -DIN_GCC -g -I. -I.. -I/exd4/billingd/src/gcc/gcc/fixinc
> -I/exd4/billingd/src/gcc/gcc/fixinc/..
> -I/exd4/billingd/src/gcc/gcc/fixinc/../config
> -I/exd4/billingd/src/gcc/gcc/fixinc/../../include -o fixincl fixincl.o
> fixtests.o fixfixes.o server.o procopen.o gnu-regex.o fixlib.o
> ../../libiberty/libiberty.a
> ld32: ERROR 33: Unresolved text symbol "dcgettext" -- 1st referenced by
> gnu-regex.o.
I believe I know why this happens. The gnu-regex.c file contain code
like this:
> #ifdef ENABLE_NLS
> # include <libintl.h>
> #else
> # define gettext(msgid) (msgid)
> #endif
This patch:
> 2000-12-13 Bruce Korb <bkorb@gnu.org>
> * fixinc/gnu-regex.c: reorder some includes to avoid _GNU_SOURCE
> warning. Also, eliminate the ``#ifdef emacs'' stuff.
moved auto-host.h above the aforementioned code. Suddenly ENABLE_NLS
is defined and we don't elide `gettext'. Since fixincl doesn't link
with libintl.a, it chokes.
The solution IMHO would be to either #undef ENABLE_NLS right after
including auto-host.h, or link with libintl.a. Since fixincl is a
"build" program, we probably don't need/want to intl it.
This patch allows fixincl to link on Irix6. OK to install?
Thanks,
--Kaveh
2000-12-14 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* fixinc/gnu-regex.c: Disable NLS.
diff -rup orig/egcs-CVS20001213/gcc/fixinc/gnu-regex.c egcs-CVS20001213/gcc/fixinc/gnu-regex.c
--- orig/egcs-CVS20001213/gcc/fixinc/gnu-regex.c Wed Dec 13 16:29:46 2000
+++ egcs-CVS20001213/gcc/fixinc/gnu-regex.c Thu Dec 14 12:51:32 2000
@@ -23,6 +23,8 @@
Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
#include "auto-host.h"
+/* GCC LOCAL: we don't need NLS here. */
+#undef ENABLE_NLS
#undef _GNU_SOURCE
#define _GNU_SOURCE