This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Java compound assignment -vs- non-String LHS
- To: apbianco at cygnus dot com
- Subject: Re: Patch: Java compound assignment -vs- non-String LHS
- From: Tom Tromey <tromey at redhat dot com>
- Date: 07 Dec 2000 16:52:59 -0700
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- References: <87u292jox4.fsf@creche.cygnus.com> <14895.19010.720791.509072@deliverance.cygnus.com>
- Reply-To: tromey at redhat dot com
>> (FWIW I'm not certain that this is the best possible error message
>> to give. I'm happy to change it if you have a different
>> preference.)
Alex> How about:
This looks good but it should say "Incompatible", not "Incompatibly":
Alex> + "Incompatibly type for `+='. Can't convert `java.lang.String' to `%s'",
I usually put two spaces after a period. This is a rule I learned in
typing class a long time ago. It is also enshrined in the GNU coding
standards (for comments anyway).
Tom