This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for the mn10300
- To: <rsandifo at redhat dot com>
- Subject: Re: Patch for the mn10300
- From: Alexandre Oliva <aoliva at redhat dot com>
- Date: 30 Nov 2000 18:06:05 -0200
- Cc: gcc-patches at gcc dot gnu dot org
- Organization: GCC Team, Red Hat
- References: <Pine.LNX.4.21.0011301909540.31772-100000@host138.cygnus>
On Nov 30, 2000, <rsandifo@redhat.com> wrote:
> The following patch replaces store_movm with two other instructions, one
> to be used on the AM33 and one to be used otherwise. Ran 'make check'
> to verify that this fixes the problem.
Thanks. I have a few nits:
> * config/mn10300/mn10300.md: Spawned two store_movm insns,
> one the AM33 and one for non-AM33 targets.
> * config/mn10300/mn10300.c (print_live_regs): Added.
Please mention the names of the patterns that you're changing in
mn10300.md. I suggest something like:
* config/mn10300/mn10300.c (print_live_regs): Added.
* config/mn10300/mn10300-protos.h (print_live_regs): Likewise.
* config/mn10300/mn10300.md (return_internal_regs): Use it.
(store_movm): Likewise.
(store_movm_am33): New.
> ! (define_insn "store_movm_am33"
Please add a condition indicating that this insn should only be used
on AM33 and above, and one to store_movm (I suggest to take out the
`_non_am33' suffix) indicating it should only be used otherwise.
Thanks!
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me