This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: SH: declare fpul_operands


On Nov 22, 2000, Joern Rennecke <amylaar@redhat.com> wrote:

>> * config/sh/sh-protos.h (fpul_operand): Declare.
> This is just papering over a problem elsewhere.  fpul_operand is
> mentioned in PREDICATE_CODES, and hence a prototype for it should
> have been generated.

Err...  Where exactly would it have been generated?  And why are so
many non-standard PREDICATE_CODES declared in sh-protos.h?

>> * config/sh/sh.c (fpul_operand): Declare MODE argument.

> It's OK to declare it, but drop the ATTRIBUTE_UNUSED.  mode is
> definitely used.

Indeed.  Somehow, I had missed its use.  Fixed.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]