This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: V3 PATCH: Fix const-correctness in use of iconv
On Fri, Nov 10, 2000 at 06:29:13PM +0100, Gabriel Dos_Reis wrote:
>
> Currently, I don't have the time, unfortunatley, to polish your patch
> -- we definitely need a codecvt.tcc. That is for the next week unless
> Bnejamin beats me...
Yeah, I thought we already /had/ a codecvt.tcc when I sent my mail.
Why don't I check this in for now so that others can start banging on it,
and then next week the parts that can be safely split off into a .tcc can be.
If anybody with a glibc 2.2 system would like to test this, you
can restrict your testsuite/200011??-mkcheckfiles.txt list to just
22_locale/ctor_copy_dtor.cc, which is an example of a program which will
not build if the signature is wrong.
Applying this patch (or getting a fresh copy once I've checked in the
unpolished version) will allow it to build. Note that this test WILL FAIL
TO RUN, but that's okay, at least it will build. (And I've been looking
into that failure, but that's another story. It is /not/ related to the
const/non-const issue.)
Phil
--
pedwards at disaster dot jaj dot com | pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools. Fools are protected by more capable fools.