This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] new FreeBSD/alpha support


On Fri, Oct 06, 2000 at 09:49:06PM -0700, David O'Brien wrote:
> +		tmake_file="t-freebsd alpha/t-crtbe"

You also need alpha/t-alpha and alpha/t-ieee.

> +/* XXX, if FreeBSD/Alpha grows a crti.o file, we can use the alpha/elf.h
> +   definition.  */
> +#undef	STARTFILE_SPEC
> +#define STARTFILE_SPEC \
> +  "%{!shared: %{pg:gcrt1.o%s} %{!pg:%{p:gcrt1.o%s} %{!p:crt1.o%s}}}	\
> +     %{!shared:crtbegin.o%s} %{shared:crtbeginS.o%s}"

What's in your crt1 that you can use crtbegin at all, then?
Seems unlikely to me that this functions.

> +#if defined(__i386__)
> +#undef  HOST_BITS_PER_LONG
> +#define HOST_BITS_PER_LONG	32
> +#undef  HOST_WIDE_INT
> +#define HOST_WIDE_INT		long long
> +#undef  HOST_BITS_PER_WIDE_INT
> +#define HOST_BITS_PER_WIDE_INT	64
> +#endif

Not approved.  There are other ways to do this.

> +#undef  ASM_OUTPUT_SOURCE_LINE
> +#define ASM_OUTPUT_SOURCE_LINE(STREAM, LINE)				\
> +  alpha_output_lineno (STREAM, LINE)

Where does this get redefined since alpha.h?

> +#undef 	CTORS_SECTION_FUNCTION
> +#define CTORS_SECTION_FUNCTION
> +#undef 	DTORS_SECTION_FUNCTION
> +#define DTORS_SECTION_FUNCTION

These are not needed -- alpha/elf.h has this taken care of.

> +/* This is how we tell the assembler that a symbol is weak.  */
> +/* XXX, alpha/elf.h does not do the ".globl".  Should FreeBSD/Alpha?  */

It's not needed -- "weak" implies "global" on all ELF systems.
Examine the set of STB_* values and it will be obvious why.



r~

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]