This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fix handling of '#pragma pack(pop [, id])'
On Sat, Sep 30, 2000 at 12:06:50AM -0500, Mike Coleman wrote:
> "Zack Weinberg" <zackw@stanford.edu> writes:
> > You must not use a variable to hold an error message, or message
> > translation will break. You have to do it like this:
>
> Ok, I didn't know about this.
>
> > Better you should set align to zero at the beginning of the function
> > and leave the switch alone.
>
> That would also work. I put the 'action != pop' check in to make it clearer
> to the reader that the switch didn't apply in the 'pop' case. Personal
> taste--your way is fine with me.
Your way is fine with me, too.
> Do I need to submit a revised patch?
Please. And maybe some test cases?
zw