This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[RFA:] Remove extraneous spacing from directives in config/elfos.h


If your ELF assembler is based on GAS, and you change ASM_FILE_START to
emit #NO_APP (not using the default from elfos.h), gas will complain about
extraneous spacing.  These were what I caught some time ago.

Bootstrapped and checked with no new failures on i686-pc-linux-gnulibc1.

Ok to commit?

2000-09-16  Hans-Peter Nilsson  <hp@axis.com>

	* config/elfos.h (CONST_SECTION_ASM_OP): Remove extraneous leading
	tab.
	(CTORS_SECTION_ASM_OP): Ditto.
	(DTORS_SECTION_ASM_OP): Ditto.
	(INIT_SECTION_ASM_OP): Ditto.
	(FINI_SECTION_ASM_OP): Ditto.
	(ASM_OUTPUT_CONSTRUCTOR): Remove extraneous space.
	(ASM_OUTPUT_DESTRUCTOR): Ditto.
	(ASM_DECLARE_FUNCTION_NAME): Ditto.
	(ASM_DECLARE_OBJECT_NAME): Ditto.
	(ASM_FINISH_DECLARE_OBJECT): Ditto.
	(ASM_DECLARE_FUNCTION_SIZE): Ditto.

Index: elfos.h
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/elfos.h,v
retrieving revision 1.19
diff -p -c -r1.19 elfos.h
*** elfos.h	2000/08/01 20:24:22	1.19
--- elfos.h	2000/09/15 22:17:50
*************** Boston, MA 02111-1307, USA.  */
*** 254,260 ****
  
  #define USE_CONST_SECTION	1
  
! #define CONST_SECTION_ASM_OP	"\t.section\t.rodata"
  
  /* Define the pseudo-ops used to switch to the .ctors and .dtors sections.
  
--- 254,260 ----
  
  #define USE_CONST_SECTION	1
  
! #define CONST_SECTION_ASM_OP	".section\t.rodata"
  
  /* Define the pseudo-ops used to switch to the .ctors and .dtors sections.
  
*************** Boston, MA 02111-1307, USA.  */
*** 271,278 ****
     errors unless the .ctors and .dtors sections are marked as writable
     via the SHF_WRITE attribute.)  */
  
! #define CTORS_SECTION_ASM_OP	"\t.section\t.ctors,\"aw\""
! #define DTORS_SECTION_ASM_OP	"\t.section\t.dtors,\"aw\""
  
  /* On svr4, we *do* have support for the .init and .fini sections, and we
     can put stuff in there to be executed before and after `main'.  We let
--- 271,278 ----
     errors unless the .ctors and .dtors sections are marked as writable
     via the SHF_WRITE attribute.)  */
  
! #define CTORS_SECTION_ASM_OP	".section\t.ctors,\"aw\""
! #define DTORS_SECTION_ASM_OP	".section\t.dtors,\"aw\""
  
  /* On svr4, we *do* have support for the .init and .fini sections, and we
     can put stuff in there to be executed before and after `main'.  We let
*************** Boston, MA 02111-1307, USA.  */
*** 280,287 ****
     The definitions say how to change sections to the .init and .fini
     sections.  This is the same for all known svr4 assemblers.  */
  
! #define INIT_SECTION_ASM_OP	"\t.section\t.init"
! #define FINI_SECTION_ASM_OP	"\t.section\t.fini"
  
  /* A default list of other sections which we might be "in" at any given
     time.  For targets that use additional sections (e.g. .tdesc) you
--- 280,287 ----
     The definitions say how to change sections to the .init and .fini
     sections.  This is the same for all known svr4 assemblers.  */
  
! #define INIT_SECTION_ASM_OP	".section\t.init"
! #define FINI_SECTION_ASM_OP	".section\t.fini"
  
  /* A default list of other sections which we might be "in" at any given
     time.  For targets that use additional sections (e.g. .tdesc) you
*************** dtors_section ()						\
*** 388,394 ****
    do								\
      {								\
        ctors_section ();						\
!       fprintf (FILE, "\t%s\t ", INT_ASM_OP);			\
        assemble_name (FILE, NAME);				\
        fprintf (FILE, "\n");					\
      }								\
--- 388,394 ----
    do								\
      {								\
        ctors_section ();						\
!       fprintf (FILE, "\t%s\t", INT_ASM_OP);			\
        assemble_name (FILE, NAME);				\
        fprintf (FILE, "\n");					\
      }								\
*************** dtors_section ()						\
*** 400,406 ****
    do								\
      {								\
        dtors_section ();                   			\
!       fprintf (FILE, "\t%s\t ", INT_ASM_OP);			\
        assemble_name (FILE, NAME);              			\
        fprintf (FILE, "\n");					\
      }								\
--- 400,406 ----
    do								\
      {								\
        dtors_section ();                   			\
!       fprintf (FILE, "\t%s\t", INT_ASM_OP);			\
        assemble_name (FILE, NAME);              			\
        fprintf (FILE, "\n");					\
      }								\
*************** dtors_section ()						\
*** 557,563 ****
  #define ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL)	\
    do							\
      {							\
!       fprintf (FILE, "\t%s\t ", TYPE_ASM_OP);		\
        assemble_name (FILE, NAME);			\
        putc (',', FILE);					\
        fprintf (FILE, TYPE_OPERAND_FMT, "function");	\
--- 557,563 ----
  #define ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL)	\
    do							\
      {							\
!       fprintf (FILE, "\t%s\t", TYPE_ASM_OP);		\
        assemble_name (FILE, NAME);			\
        putc (',', FILE);					\
        fprintf (FILE, TYPE_OPERAND_FMT, "function");	\
*************** dtors_section ()						\
*** 574,580 ****
  #define ASM_DECLARE_OBJECT_NAME(FILE, NAME, DECL)		\
    do								\
      {								\
!       fprintf (FILE, "\t%s\t ", TYPE_ASM_OP);			\
        assemble_name (FILE, NAME);				\
        putc (',', FILE);						\
        fprintf (FILE, TYPE_OPERAND_FMT, "object");		\
--- 574,580 ----
  #define ASM_DECLARE_OBJECT_NAME(FILE, NAME, DECL)		\
    do								\
      {								\
!       fprintf (FILE, "\t%s\t", TYPE_ASM_OP);			\
        assemble_name (FILE, NAME);				\
        putc (',', FILE);						\
        fprintf (FILE, TYPE_OPERAND_FMT, "object");		\
*************** dtors_section ()						\
*** 586,592 ****
  	  && (DECL) && DECL_SIZE (DECL))			\
  	{							\
  	  size_directive_output = 1;				\
! 	  fprintf (FILE, "\t%s\t ", SIZE_ASM_OP);		\
  	  assemble_name (FILE, NAME);				\
  	  putc (',', FILE);					\
  	  fprintf (FILE, HOST_WIDE_INT_PRINT_DEC,		\
--- 586,592 ----
  	  && (DECL) && DECL_SIZE (DECL))			\
  	{							\
  	  size_directive_output = 1;				\
! 	  fprintf (FILE, "\t%s\t", SIZE_ASM_OP);		\
  	  assemble_name (FILE, NAME);				\
  	  putc (',', FILE);					\
  	  fprintf (FILE, HOST_WIDE_INT_PRINT_DEC,		\
*************** dtors_section ()						\
*** 616,622 ****
  	  && !size_directive_output)				\
  	{							\
  	  size_directive_output = 1;				\
! 	  fprintf (FILE, "\t%s\t ", SIZE_ASM_OP);		\
  	  assemble_name (FILE, name);				\
  	  putc (',', FILE);					\
  	  fprintf (FILE, HOST_WIDE_INT_PRINT_DEC,		\
--- 616,622 ----
  	  && !size_directive_output)				\
  	{							\
  	  size_directive_output = 1;				\
! 	  fprintf (FILE, "\t%s\t", SIZE_ASM_OP);		\
  	  assemble_name (FILE, name);				\
  	  putc (',', FILE);					\
  	  fprintf (FILE, HOST_WIDE_INT_PRINT_DEC,		\
*************** dtors_section ()						\
*** 641,647 ****
  	  ASM_GENERATE_INTERNAL_LABEL (label, "Lfe", labelno);	\
  	  ASM_OUTPUT_INTERNAL_LABEL (FILE, "Lfe", labelno);	\
  	  							\
! 	  fprintf (FILE, "\t%s\t ", SIZE_ASM_OP);		\
  	  assemble_name (FILE, (FNAME));			\
  	  fprintf (FILE, ",");					\
  	  assemble_name (FILE, label);				\
--- 641,647 ----
  	  ASM_GENERATE_INTERNAL_LABEL (label, "Lfe", labelno);	\
  	  ASM_OUTPUT_INTERNAL_LABEL (FILE, "Lfe", labelno);	\
  	  							\
! 	  fprintf (FILE, "\t%s\t", SIZE_ASM_OP);		\
  	  assemble_name (FILE, (FNAME));			\
  	  fprintf (FILE, ",");					\
  	  assemble_name (FILE, label);				\

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]