This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: proposed testsuite entry. Re: new #pragma pack failure


On Sun, Sep 10, 2000 at 11:06:22PM -0500, Robert Lipe wrote:
> Zack, with your patch installed, my build gets a lot quieter.  Thanx!
> 
> Richard Henderson wrote:
> > On Sat, Sep 09, 2000 at 07:36:50PM -0500, Robert Lipe wrote:
> > > So while I could make the tests run only where HANDLE_SYSV_PRAGMA is
> > > set, they still wouldn't get run on the "mainstream" GCC development
> > > hosts, would they?
> > 
> > Linux and *BSD define HANDLE_SYSV_PRAGMA.
> 
> OK.  You talked me into it.  The following testcase will fail with the
> current tree and will pass with Zack's patch above installed.  It will
> also fail if pragma pack doesn't actually work.  
> 
> This is hardly general purpose code, but it should at least share my
> pragma pack joys with many of my other IA32 brethren.  We could make it
> a _better_ test as long as we're inclined to test IA32 only by testing
> against struct sizes that we divinely known to be true instead of
> testing only the relative sizes of the structs.

The test case looks more or less sensible to me.

I went ahead and checked in the patch to c-pragma.c.

zw

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]