This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc intrinsics for am33 parallel integer arithmetic
On Sep 2, 2000, Eric Christopher <echristo@cygnus.com> wrote:
> There are a lot of cases like this in the patch:
> + void
> + am33_init_builtins ()
> + {
> + if (TARGET_AM33)
Which reminds me of another issue: every function must be preceded by
comments explaining, in plain text, what the function does, and, when
applicable, what its arguments are and what it returns.
> Perhaps it would be better if there was a general mn10300_init_builtins
> func that checked for TARGET_AM33 and init based on the specific
> processor variant?
Agreed. Either that or move the test for TARGET_AM33 to
MD_INIT_BUILTINS, so that am33_init_builtins reflects the fact it is
am33-specific.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me