This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: SSA for hard registers


On Jul 31, 2000, Richard Henderson <rth@cygnus.com> wrote:

> On Mon, Jul 31, 2000 at 10:35:46AM -0700, Mark Mitchell wrote:
>> + /* We cannot use <assert.h> in GCC source, since that would include
>> +    GCC's assert.h, which may not be compatible with the host compiler.  */
>> + #undef assert
>> + #ifdef NDEBUG
>> + # define assert(e)
>> + #else
>> + # define assert(e) do { if (! (e)) abort (); } while (0)
>> + #endif

> The entire rest of the source base uses `if (!e) abort()';
> I don't see that we should make an exception here.

Think of:

  if (something)
    assert (a == b);
  else
    do_something_else;

Having if/abort enclosed in a do/while(0) and `e' enclosed in
parentheses is the only way to make it behave as expected.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]