This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix i386 PIC breakage
- To: Jakub Jelinek <jakub at redhat dot com>
- Subject: Re: [PATCH] Fix i386 PIC breakage
- From: Jan Hubicka <jh at suse dot cz>
- Date: Thu, 13 Jul 2000 15:03:33 +0200
- Cc: rth at cygnus dot com, jh at suse dot cz, gcc-patches at gcc dot gnu dot org
- References: <20000713114819.S17419@sunsite.ms.mff.cuni.cz>
> Hi!
>
> Sat Jul 8 01:38:25 MET DST 2000 Jan Hubicka <jh@suse.cz>
>
> * i386.md (call_pop, call, call_value_pop): Do not set
> current_function_uses_pic_offset_table for calls to static
> functions or indirect calls.
>
> broke PIC support on i386.
Oops... silly cut&paste bug. I wonder why it didn't prevented glibc
from compile for me....
Note that you need to also fix the fourth copy in call_value pattern. Perhaps
the SYMBOL_REF thest can really go into constant_call_address_operand. I don't
think the code will work with other constructs (LABEL_REFS etc.) anyway
(construct PLT entry etc). It already contains GET_CODE (XEXP (op, 0)) !=
CONST_INT, so perhaps it can be GET_CODE (XEXP (op, 0)) == SYMBOL_REF
Thanks,
Honza