Re: web/375: Re: GCC gnatsweb

[Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>]

>>Number:         375
>>Category:       web
>  * The login page makes no mention of needing to have cookies
>  enabled; but without cookies enabled it just redirects to another login
>  page (under Netscape) or goes to a "Redirecting" page which does nothing
>  (under lynx).

GNATSweb is trying to be overly clever and thus miserably fails with the
annoying failure mode you observed.
 
There *are* checks whether your browser accepts cookies, but these are
implemented using Javascript. Of course many (if not most) of those who
cannot or do not want to use Cookies also cannot or do not want to use
Javascript! <ouch>

Fixed by the patch below which I already installed.

Thanks for pointing this out!
Gerald

PS: I don't see how to address the other issues you pointed out in the
PR right now. In the future, I suggest to submit separate reports for
different issues (even if they can be summarized under one "meta-issue".)

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.7
retrieving revision 1.10
diff -c -3 -p -r1.7 -r1.10
*** gnatsweb.pl	2000/05/11 07:00:34	1.7
--- gnatsweb.pl	2000/07/04 09:03:52	1.10
*************** delCookie("gnatsweb-test-cookie");
*** 2894,2901 ****
  if (val == null) {
      document.write("<h2>Warning: your browser is not accepting cookies</h2>"
          + "Gnatsweb requires cookies to keep track of your login and other "
!         + "information.  Please enable cookies before pressing the "
!         + "<tt>login</tt> button.");
  }
  
  //-->
--- 2894,2900 ----
  if (val == null) {
      document.write("<h2>Warning: your browser is not accepting cookies</h2>"
          + "Gnatsweb requires cookies to keep track of your login and other "
!         + "information.  Please enable cookies before logging in.");
  }
  
  //-->
*************** sub login_page
*** 2929,2935 ****
    # are not really needed; use the username as the default.
    my $def_password = $db_prefs{'password'} || $ENV{'REMOTE_USER'};
    print $q->start_form(),
!         "<p>Use username '<b>guest</b>' and password '<b>guest</b>' for read-only and bug reporting access.",
          "<table>",
          "<tr><td>User Name:<td>",
          $q->textfield(-name=>'user',
--- 2928,2938 ----
    # are not really needed; use the username as the default.
    my $def_password = $db_prefs{'password'} || $ENV{'REMOTE_USER'};
    print $q->start_form(),
!         "<p>Use username '<b>guest</b>' and password '<b>guest</b>' for".
!         " read-only and bug reporting access.",
!         " Unfortunately, GNATSweb requires cookies to keep track".
!         " of your login and other information.  Please enable cookies".
!         " before logging in.",
          "<table>",
          "<tr><td>User Name:<td>",
          $q->textfield(-name=>'user',