This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: mips.c machine_dependent_reorg fix
- To: law at cygnus dot com
- Subject: Re: mips.c machine_dependent_reorg fix
- From: Joern Rennecke <amylaar at cygnus dot co dot uk>
- Date: Wed, 31 May 2000 16:12:08 +0100
- Cc: gcc-patches at gcc dot gnu dot org
- Newsgroups: cygnus.egcs.patches
In article <10436.959725891@upchuck> you wrote:
: You need to provide a description of why that change is the correct change
: to make.
1) It makes it consistent with the CONSTANT_POOL_ADDRESS_P case
2b) mode is only used if val is used.
2c) max_internal_pool_size is the maximum total constant pool size that
we're still have to emit, and it shrinks with each constant we examine,
no matter if we do place it in an extra constant pool or if we find that
we don't need to after all.
The fact that the way this is used incorrectly is IMHO a separate
matter; the most straightforward fix would be to add another variable
that accumulates the size of the currently constructed pool's size,
which is cleared whenever the pool is written out, and taken into
account for the distance computations.
3) You added the code just two years ago, so you should have a general idea
what it is doing.