This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fixproto fix


  In message <3924D74A.352A36A6@softhome.net>you write:
  > Jeffrey A Law wrote:
  > >   >     * fixproto: Recognize DOS paths with drive letters as absolute pa
  > ths.
  > > This can't be correct since it will mess up on systems which allow direct
  > ory
  > > names like c; (ie every unix system I'm aware of).
  > 
  > Sorry, I don't understand why patch is wrong. I've 
  > 
  > +case $rel_target_dir in
  > +  /* | [A-Za-z]:[\\/]*)
  > +     abs_target_dir=$rel_target_dir
  > 
  > If you mean directory names like 'c;/foo', they will be corectly recognized
  > as relative - the patch checks for presence of ':', which is not allowed in
  > file names.
My point is on a unix system ':' is an allowed file/directory name.

Let me put it another way

c:/blah is an absolute on a dos based filesystem, but relative on a unix
based filesystem.

Therefore code which unconditionally assumes that kind of path is absolute
or relative is broken since the interpretation of that path is dependent
on the host filesystem.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]