This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 64-bit mn10300 prologue bug
- To: law at cygnus dot com
- Subject: Re: 64-bit mn10300 prologue bug
- From: Alexandre Oliva <aoliva at cygnus dot com>
- Date: 18 May 2000 21:49:54 -0300
- Cc: gcc-patches at gcc dot gnu dot org
- Organization: Cygnus Solutions, a Red Hat Company
- References: <4336.958678262@upchuck>
On May 18, 2000, Jeffrey A Law <law@cygnus.com> wrote:
> In message <orya57mzp7.fsf@saci.lsd.ic.unicamp.br>you write:
>> While I was at it, I modified some types so that we'll get correct
>> code on 16-bit hosts, as well as 32-bit and 64-bit ones.
> Wouldn't it make more sense to make size an "unsigned HOST_WIDE_INT"?
As rth pointed out, HOST_WIDE_INT (signed) makes even more sense :-)
> If that works, consider it approved.
Here's what I'm checking in:
Index: gcc/ChangeLog
from Alexandre Oliva <aoliva@cygnus.com>
* config/mn10300/mn10300.c (expand_prologue, expand_epilogue):
16-bit and 64-bit clean-up.
Index: gcc/config/mn10300/mn10300.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/mn10300/mn10300.c,v
retrieving revision 1.27
diff -u -r1.27 mn10300.c
--- gcc/config/mn10300/mn10300.c 2000/05/11 21:08:18 1.27
+++ gcc/config/mn10300/mn10300.c 2000/05/19 00:46:24
@@ -380,7 +380,7 @@
void
expand_prologue ()
{
- unsigned int size;
+ HOST_WIDE_INT size;
/* SIZE includes the fixed stack space needed for function calls. */
size = get_frame_size () + current_function_outgoing_args_size;
@@ -421,7 +421,7 @@
void
expand_epilogue ()
{
- unsigned int size;
+ HOST_WIDE_INT size;
/* SIZE includes the fixed stack space needed for function calls. */
size = get_frame_size () + current_function_outgoing_args_size;
--
Alexandre Oliva Enjoy Guaranį, see http://www.ic.unicamp.br/~oliva/
Cygnus Solutions, a Red Hat company aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org} Write to mailing lists, not to me