This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: INSN_P candidates


Hi Graham,

: I think we can go a little bit further with these INSN_P changes,
: GCC also uses (GET_RTX_CLASS (code) == 'i'). 
: 
: If we introduce a new macro in rtl.h call it INSN_CODE_P() (couldn't
: think of anything better) then we can replace instances of this
: code pattern and its != variant with the new macro.
: 
: Hence I propose we introduce an INSN_CODE_P () macro defined as
: 
: #define INSN_CODE_P (CODE)	(GET_RTX_CLASS (CODE) == 'i')
: 
: and also use this to define the INSN_P macro as
: 
: #define INSN_P(INSN)	INSN_CODE_P (GET_CODE (INSN))
: 
: Comments?

Seems like a reasonable idea to me, although since it is mainly a
cosmetic change I am not sure how time people would want to spend
converting the sources.

Still, when you do get the sources on your machine, why don't you try
generating a patch to implement it, and then see what happens when you
submit it.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]