This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: AM33: Use macros instead of register number constants


On Apr 27, 2000, Jeffrey A Law <law@cygnus.com> wrote:

> Given how you adjusted other case, I suspect you wanted that to be i
> <= LAST_EXTENDED_REG.

Yup.

> You should probably move the definitions of those macros before their
> first uses.

Is that really necessary?  Or just for clarity?

> Otherwise it seems OK.

Thanks, I'll probably check it in after getting some sleep, so that I
don't mess it up.  Thanks for pointing out my mistake.  I'm a bit
surprised that it didn't trigger any failure.  But it might be that I
posted this one without a full build, being a zero functionality
change patch.  ``It can't break anything'', I may have though. :-)

-- 
Alexandre Oliva    Enjoy Guaranį, see http://www.ic.unicamp.br/~oliva/
Cygnus Solutions, a Red Hat company        aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist    CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org}   Write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]