This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch for unsigned bitfields
On Tue, Apr 18, 2000 at 02:34:49PM -0500, Robert Lipe wrote:
> > > +AC_MSG_CHECKING(for unsigned enumerated bitfields)
> > > +AC_CACHE_VAL(gcc_cv_enum_bf_unsigned,
> >
> > AC_CACHE_CHECK(for unsigned enumerated bitfields, gcc_cv_enum_bf_unsigned,
> >
> > ...
> > > + AC_DEFINE(ENUM_BITFIELDS_ARE_UNSIGNED)
> >
> > If you write this as
> >
> > AC_DEFINE(ENUM_BITFIELDS_ARE_UNSIGNED, 1,
> > [Define if enumerated bitfields are treated as unsigned values.])
> >
> > then you don't have to add anything to acconfig.h.
>
> I had noticed these forms in the autoconf doc. I made a conscious
> decision to mimic the style used elsewhere in gcc/configure.in instead
> of using those. (When in Rome...) Certainly I don't feel strongly
> about it. I have now committed that with your suggestions incorporated.
I don't feel strongly about AC_CACHE_VAL/CHECK, but I do think the
three-argument form of AC_DEFINE is much more maintainable than having
to remember to update acconfig.h. Also, Kaveh's meaning to patch all
the one-argument AC_DEFINEs and make acconfig.h much shorter (empty,
if possible). Let's not give him more work.
zw