This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: PATCH: Preprocessor line-numbering bug

To: zack at wolery dot cumb dot org
Subject: Re: PATCH: Preprocessor line-numbering bug
From: Mark Mitchell <mark at codesourcery dot com>
Date: Tue, 18 Apr 2000 12:41:39 -0700
Cc: gcc-patches at gcc dot gnu dot org
Organization: CodeSourcery, LLC
References: <20000418115930H.mitchell@codesourcery.com><20000418122416.V10660@wolery.cumb.org>

>>>>> "Zack" == Zack Weinberg <zack@wolery.cumb.org> writes:

    Zack> On Tue, Apr 18, 2000 at 11:59:30AM -0700, Mark Mitchell
    Zack> wrote:
    >>  This patch fixes a bug in the preprocessor whereby
    >> line-numbers in the preprocessed output were incorrect.  I
    >> committed this, but, Zack, I'd appreciate it if you would take
    >> a look and tell me if this looks right to you.
    >> Bootstrapped/checked on i686-pc-linux-gnu.

    Zack> We had an active mark at that point because we were looking
    Zack> ahead for an open paren?  If that's why, the patch is fine.

Yes, that's right.  Sorry I didn't explain that more clearly.

    Zack> Note I usually prefer to have preprocessor tests in gcc.dg.

OK.  Henceforth, that's where I'll put them.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

References:
- PATCH: Preprocessor line-numbering bug
  - From: Mark Mitchell
- Re: PATCH: Preprocessor line-numbering bug
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]