This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for fix-header crashes
- To: gcc-patches at gcc dot gnu dot org, zack at wolery dot cumb dot org
- Subject: Re: Patch for fix-header crashes
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Tue, 18 Apr 2000 13:03:35 -0400 (EDT)
- Cc: David dot Billinghurst at riotinto dot com dot au, mrs at windriver dot com
> From: Zack Weinberg <zack@wolery.cumb.org>
>
> This patch fixes a number of bugs any of which could have caused
> fix-header to crash. There were basically two problems: not checking
> the return value of cpp_file_buffer, and assuming that tokens were
> nul-terminated (which they were sometimes, but not always).
>
> This may cause more bugs to crawl out of the woodwork, because tokens
> are never nul-terminated now. It did pass bootstrap and regression.
> I won't commit it until it manages to compile glibc and X.
> zw
This morning's CVS, which contains this patch, works for me on
solaris2.7, AIX4, OSF4 and Irix6, (where previously it didn't.)
Thanks Zack.
--Kaveh
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions