This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH]: warning on implicit float->int
- To: nathan at codesourcery dot com
- Subject: Re: [C++ PATCH]: warning on implicit float->int
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Fri, 03 Mar 2000 10:33:42 -0800
- Cc: jason at cygnus dot com, gcc-patches at gcc dot gnu dot org, j dot kuipers at chello dot nl
- Organization: CodeSourcery, LLC
- References: <38BA49F3.FE2D3D78@codesourcery.com><u9aekljlvg.fsf@yorick.cygnus.com><38BF92BA.9799E4F2@codesourcery.com>
Nathan --
This patch looks good. A few minor suggestions:
There's no test-case with the patch. Is there one we can add, or is
there one already in the test-suite that now passes? I just love test
cases. :-)
! /* Perform the conversions in CONVS on the expression EXPR.
! FN and ARGNUM are used for diagnostics. INNER is non-zero when
! being called to continue a conversion chain. */
static tree
! convert_like (convs, expr, fn, argnum, inner)
Should say whether ARGNUM is indexed from zero or one. Should
document the fact that -1 means "no argnum", if I read correctly.
Also, I would prefer a macro that hides the `inner' argument from
callers.
Please check in the patch with those changes. And thanks!
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com