This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: -fleading-underscore fix for elf targets
- To: Geoff Keating <geoffk at cygnus dot com>
- Subject: Re: -fleading-underscore fix for elf targets
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sat, 26 Feb 2000 07:35:59 -0700
- cc: gcc-patches at gcc dot gnu dot org
- Reply-To: law at cygnus dot com
In message <200002252028.MAA06374@localhost.cygnus.com>you write:
>
> This fixes a problem with -fleading-underscore on m68k/elf, and lots
> of other places; it also makes -fno-leading-underscore work on sh-elf.
> Tested on sparc-solaris and sh-elf.
>
> The basic idea is that it's never right to specify ASM_OUTPUT_LABELREF
> without using %U, because the user can change %U. It may be silly
> for the user to specify -fno-leading-underscores if that's not the
> default, but it's allowed and might occasionally be useful. It's
> always valid to specify -fleading-underscores; that's just like
> putting an underscore in front of identifiers in the source.
>
> OK to commit?
>
> --
> - Geoffrey Keating <geoffk@cygnus.com>
>
> ===File ~geoffk/patches/cygnus/gcc-102725-2.patch===========
> 2000-02-25 Geoff Keating <geoffk@cygnus.com>
>
> * config/elfos.h (ASM_OUTPUT_LABELREF): Don't define. The default
> is right for most ELF targets.
> * config/ns32k/ns32k.h (ASM_OUTPUT_LABELREF): Don't define.
> Let the default file use %U properly.
> * config/sh/elf.h (ASM_OUTPUT_LABELREF): Don't define. Use the
> default.
This is fine. Please install this patch.
Thanks,
jeff