This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: newppc-branch: Cleanups again
- To: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- Subject: Re: newppc-branch: Cleanups again
- From: Geoff Keating <geoffk at cygnus dot com>
- Date: 19 Feb 2000 14:31:40 -0800
- CC: gcc-patches at gcc dot gnu dot org
- References: <00021919464301.18971@enzo.bigblue.local>
Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:
> Hi,
>
> my next bunch of cleanups for the newppc-branch.
>
> OK to commit?
>
>
> I'm still looking at these macros conflicting between rs6000.h and sysv4.h:
>
> - STRICT_ALIGNMENT, STACK_BOUNDARY, BIGGEST_ALIGNMENT, etc: I'm leaning towards
> moving all alignment macros (except SLOW_UNALIGNED_ACCESS) from rs6000.h to
> aix.h and duplicate some for sysv4.h. Opinions?
>
> - ASM_OUTPUT_SPECIAL_POOL_ENTRY_P, ENCODE_SECTION_INFO: these 2 look like
> candidates for merging the versions in rs6000.h and sysv4.h?
>
> - ASM_OUTPUT_INT: move from rs6000.h to aix.h?
>
> Franz.
>
>
> * aix.h (FP_SAVE_INLINE, ASM_OUTPUT_INTERNAL_LABEL_PREFIX,
> TEXT_SECTION_ASM_OP, DATA_SECTION_ASM_OP: Move here...
> * rs6000.h: from here.
Some of this won't apply because of my recent commit. Sorry about
that. Try again?
> * rs6000.h (CPP_DEFAULT_SPEC): Change to empty string.
> * aix.h (CPP_DEFAULT_SPEC): Define default for AIX.
Hmmm. Actually, this should be triggered off TARGET_CPU_DEFAULT. I
wonder if we can change it in OVERRIDE_OPTIONS? Then we could delete
the whole macro. There are a number of places where we define some
bit of the spec based on the CPU type and get it only half-right.
> * rs6000-protos.h (rs6000_select_section): Provide prototype.
> (rs6000_select_rtx_section): Likewise.
> (rs6000_encode_section_info): Likewise.
> (sdata_section): Likewise.
> (sdata2_section): Likewise.
> (sbss_section): Likewise.
> * sysv4.h (rs6000_select_section): Delete prototype.
> (rs6000_select_rtx_section): Likewise.
> (rs6000_encode_section_info): Likewise.
> (sdata_section): Likewise.
> (sdata2_section): Likewise.
> (sbss_section): Likewise.
> (REG_SAVE_AREA): Delete definition duplicated in rs6000.h.
This is good.
> * sysv4.h: Delete various unnecessary #undef's and put a comment
> on the remaining ones
> Change various comments according to coding standard.
This is good too.
--
- Geoffrey Keating <geoffk@cygnus.com>