This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Proposal and patch: Allow whitespace in md constraints
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Subject: Re: Proposal and patch: Allow whitespace in md constraints
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Tue, 15 Feb 2000 19:19:02 -0700
- cc: Michael Meissner <meissner at cygnus dot com>, gcc-patches at gcc dot gnu dot org
- Reply-To: law at cygnus dot com
In message <Pine.BSF.4.10.10002141649380.29802-100000@dair.pair.com>you write
:
> On Mon, 14 Feb 2000, Michael Meissner wrote:
> > On Mon, Feb 14, 2000 at 03:48:48PM -0500, Hans-Peter Nilsson wrote:
> > > Ok, then. Is it ok to commit, replacing strip_whitespace with your
> > > implementation? I'll add you to the ChangeLog entry, if you don't mind
> .
> >
> > Sure go ahead and commit it.
>
> Sorry to pest you again. I didn't commit, since I got const-discarded
> compilation warnings, and I noticed there was a NULL-check right *after*
> the "stripping" in the original patch.
>
> I believe I have to ask for renewed permission to check in this. Here's
> the updated part, the rest is as approved:
When testing a pointer against null I would recommend
blah != NULL
instead of
blah != 0
Otherwise it seems fine to me.
jeff