This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcj bytecode generation patch
- To: green at redhat dot com
- Subject: Re: gcj bytecode generation patch
- From: Per Bothner <per at bothner dot com>
- Date: 30 Jan 2000 20:36:05 -0800
- Cc: gcc-patches at sourceware dot cygnus dot com
- References: <200001302210.OAA31829@decepticon.cygnus.com>
Anthony Green <green@cygnus.com> writes:
> + {
> + /* Pointers use 1 stack slot no matter what the target's
> + pointer size is. */
> + if (TREE_CODE (TREE_TYPE (exp)) == POINTER_TYPE)
> + NOTE_POP (1);
> + else
> + NOTE_POP (TYPE_PRECISION (TREE_TYPE (exp)) > 32 ? 2 : 1);
> + }
I would combine the two cases, perhaps like this:
int is_wide = (TREE_CODE (TREE_TYPE (exp)) != POINTER_TYPE
&& TYPE_PRECISION (TREE_TYPE (exp)) > 32);
NOTE_POP (is_wide ? 2 : 1);
--
--Per Bothner
per@bothner.com http://www.bothner.com/~per/