This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for ARM java: gcjh
- To: Scott Bambrough <scottb at netwinder dot org>
- Subject: Re: Patch for ARM java: gcjh
- From: Tom Tromey <tromey at cygnus dot com>
- Date: Fri, 28 Jan 2000 14:35:58 -0800 (PST)
- Cc: gcc patches mailing list <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at cygnus dot com>
- References: <3891ED0D.8EC43DD4@netwinder.org>
>>>>> "Scott" == Scott Bambrough <scottb@netwinder.org> writes:
Scott> * gcc/java/gjavah.c (D_NAN_MASK): Alternate definition required when
Scott> FLOAT_WORDS_BIG_ENDIAN is defined to be 1
This part is not quite correct.
gcjh runs on the host, not the target.
So we should be looking at HOST_FLOAT_WORDS_BIG_ENDIAN.
Also I think we should use "#if" and not "#ifdef" (like real.h).
Finally your patch uses "else" and not "#else".
It would be cool if gjavah.c used union DWord instead of its own
union. It would also be nice to change the code part instead of
changing the infinity define.
Alex will have to look at the other part. I imagine the same
considerations apply.
Tom