Re: am-uclinux-patch

[Richard Earnshaw <rearnsha at arm dot com>]

Phil has already provided some technical points, I've a couple of more 
general ones.

1) Do you have a copyright assignment on file with the FSF?  This change 
is large enough to need one.

2) Your ChangeLog entry is incorrectly formatted.  See the existing file 
for examples.

2000-01-08  Vadim Lebedev <vlebedev@aplio.fr>

  *  config.sub          Added arm-uclinux target
  *  gcc/Configure   modified arm-uclinux-target to use t-arm-uclinux
fragment
  *  gcc/config/arm/arm.c added usage of ARM_SUBTARGET_OVERRIDE_OPTION in
                                arm_override_options
                                arm_legitimize_pic_address modified to
generate indirection throug
                                GOT ONLY if NEED_GOT_RELOC is true

  *   gcc/config/arm/arm.h  added define ARM_FLAG_LAST_USED_BIT to specify
last used bit
                                in target_flags

  *  gcc/config/arm/uclinux-elf.h  modified to support -mno-got option

Apart from the "date" line, all lines start with a single tab.
File names are introduced with a '*' followed by a single space, the 
filename, another space, the name of the function changed in parenthesis, 
a colon and then the description of the change.  The change must be a full 
sentence starting with a capital letter and ending with a period (.).  
Changes to more than one function in a file can be introduced by naming 
subsequent functions on a new line (in parentheses followed by a colon).  
No lines must be longer than 80 columns.  Note, the filename "Configure" 
is *not* the same as the filename "configure".  Also note that gcc has 
more than one ChangeLog file; changes need to go in the appropriate one, 
so you need to split up your changes and log messages accordingly.

Richard.